CMP-4439: Add manual rule kubevirt-restrict-update-access-to-cdi-cr (CIS OCP-Virt 1.14) - #14939
Conversation
|
Hi @taimurhafeez. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM on the rule content. Two asks: (1) rebase to drop the duplicated build-script/docs change once #14920 merges; (2) use the fully-qualified |
rhmdnd
left a comment
rhmdnd
left a comment
There was a problem hiding this comment.
Looks good, just need to rebase and then update the description so that users know they can use CustomRules to automate this.
| and cloned within the cluster. Unrestricted update access allows | ||
| any subject to modify CDI settings, potentially enabling insecure | ||
| data import sources, disabling TLS verification, or altering | ||
| storage configurations. |
There was a problem hiding this comment.
We discussed manual rules with the team. The consensus is that manual rules serve as signals for customers to create their own CustomRules that replace the manual check with an environment-specific automated check.
We can update the description to make this more apparent:
Because the set of authorized subjects is specific to each
organization, this rule requires manual verification. Organizations
can create a compliance-operator CustomRule with CEL expressions
that evaluate ClusterRoleBindings and Roles to verify that only
their approved subjects hold update access to CDI resources.
…CIS OCP-Virt 1.14)
…iption that explains manual status and points organizations to CustomRules for automation. Co-Authored-By: Claude Opus 4.6 (1M context)
249ae34 to
daa2a49
Compare
openshift-ci
Bot
added
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Add a manual rule for CIS OCP-Virt control 1.14 "Restrict update access to the CDI CR". The rule documents the audit procedure (oc adm policy who-can update cdi) and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly
Co-Authored-By: Claude